search

cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

Update react context #54

Closed HenriBeck closed 5 years ago

HenriBeck commented 5 years ago

I still need to update the README because I had to remove a few things like the themeListener and the concept of channels.

TrySound commented 5 years ago

Did you tried to use react-test-renderer? It has better support being part of react repository. It doesn't require config.

kof commented 5 years ago

Actually I would strongly recommend https://github.com/kentcdodds/react-testing-library it is in the list of recommended testing libs and offers a slightly different approach compared to jest.

HenriBeck commented 5 years ago

Yeah, I'm also a fan of the react-testing-libary. Let's move to it in another PR?

kof commented 5 years ago

Yeah, I'm also a fan of the react-testing-libary. Let's move to it in another PR?

sure

kof commented 5 years ago

@iamstarkov wanna review this one as well?

HenriBeck commented 5 years ago

There are a few things I would like to do before releasing a major version, upgrade babel and move the build process to rollup (similar to the one in the monorepo) and maybe even move the testing to react-testing-libary.

I think we could release this one before react-jss and with react-jss v10 we can move to the new theming version.

HenriBeck commented 5 years ago

Is this good to go @kof?

kof commented 5 years ago

btw. mb we should just move this one into monorepo as well.

kof commented 5 years ago

ah no, it has no direct relation with jss, so could stay separate, even though I think nobody uses it separately.

HenriBeck commented 5 years ago

Yeah, it doesn't make sense to move it into the jss monorepo