search

cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

Update link for webpackbin to codesandbox #56

Closed rob2d closed 6 years ago

rob2d commented 6 years ago

This fixes issue #51 referenced/provided by @alex996

HenriBeck commented 6 years ago

I have some concerns with the code in the sandbox. I think there are some bad practices and we should provide a better example.

rob2d commented 6 years ago

Agreed. Was just providing a link provided by @alex996 as current one is 100% broken 🤒

HenriBeck commented 6 years ago

I created a new code sandbox and updated the link. @kof and @rob2d, please have a look at the sandbox.

https://codesandbox.io/s/n7737w10ol

alex996 commented 6 years ago

Maybe we could add an examples folder with the source from the sandbox? It'd make it easier to contribute. We can still keep the link to the sandbox for a live example, but then we'd need to make sure to keep the two in sync. Anyhow, just a suggestion.