search

cssinjs / theming

Unified CSSinJS theming solution for React
300 stars 39 forks source link

Exported ThemeProviderProps #67

Closed janhartmann closed 5 years ago

janhartmann commented 5 years ago

This pull requests supports that you are able to use ThemeProviderProps in your components.

HenriBeck commented 5 years ago

Do you really need the export? I think it would be simpler by just setting the theme prop manually.

janhartmann commented 5 years ago

I like the contract between the component and the theme provider, to ensure the property is set from the ThemeProvider and not set by the user.

HenriBeck commented 5 years ago

Okay, can you then also export the same type factory for flow? We should keep the types aligned as much as possible