search

cssivision / react-native-qrcode

a minimalist qrcode component for react-native
MIT License
853 stars 304 forks source link

Make canvas transparent #55

Open Slowyn opened 6 years ago

Slowyn commented 6 years ago

Problem: image Current implementation doesn't allow to create qr-code with transparent backgrounds.

This PR turns transparency by default.

yhsiang commented 5 years ago

@cssivision will you merge this?

This PR fixed our problem, when we have two themes, light and dark.

QRCode view will break in dark view, so we need make background color be transparent.

Especially we have this problem on android phone.

balthazar commented 5 years ago

Published react-native-qrcode-transparent based on this PR while we wait

Slowyn commented 5 years ago

Guys, sad news, the repo is officially no longer maintained. Someone should take a project at his hand. @balthazar It would be nice if you could maintain and develop your fork further. You should make PR with the link from this project to yours. @cssivision Are you agree to this and will you accept the incoming PR?

balthazar commented 5 years ago

Unfortunately not possible for me, as I already have a couple repos to maintain.

Slowyn commented 5 years ago

Well, probably I can take maintenance. We'll see.

cssivision commented 5 years ago

that is great, if someone can take the maintenance.

AkshatGiri commented 5 years ago

I can commandeer the repo if the the owner is okay with it.