csstools / postcss-preset-env

Convert modern CSS into something browsers understand
https://github.com/csstools/postcss-plugins/tree/main/plugin-packs/postcss-preset-env
Creative Commons Zero v1.0 Universal
2.22k stars 90 forks source link

PostCSS Values Parser warning #228

Closed Antonio-Laguna closed 2 years ago

Antonio-Laguna commented 2 years ago

As a result of #225 , @romainmenke discovered that postcss-values-parser package has an issue given that it modifies the prototype of postcss/lib/container this means that if you have multiple versions of the postcss-values-parser you can run into unexpected issues.

We've normalised all of the usages of this plugin into a single version so it's deduped but if you run the following command:

npm ls --depth 2 | grep postcss-values-parser

And don't get something along these lines where there's a single version (6.0.1) you might run into issues.

│ ├─┬ postcss-values-parser@6.0.1
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
│ ├── postcss-values-parser@6.0.1 deduped
Antonio-Laguna commented 2 years ago

Reported on the package: https://github.com/shellscape/postcss-values-parser/issues/143

Antonio-Laguna commented 2 years ago

Fixed as of https://github.com/csstools/postcss-plugins/commit/b1c4d2768179ba0d3e1f2b38e295ce8e908fa242