This moves to using enhanced-resolve for resolving reporters in the CLI. Primarily because it is more up to date with the node resolution algorithm, but seems we dropped a few deep dependencies along the way too (which is good).
you can see it caught a bug in one of our fixtures (missing package exports) which node's own algorithm would disallow (and enhanced-resolve does too)
in future i feel like this should actually just use import.meta.resolve(path, base). however, that signature is only available behind a flag in node. I did also make a branch using the ponyfill (import-meta-resolve on npm) instead of this but it will refuse to import a directory from our ESM sources (rightly so) so the tests fail
if you'd prefer that, i'd be happy to push the branch
lahmatiy
commented
1 month ago
This moves to using
enhanced-resolvefor resolving reporters in the CLI. Primarily because it is more up to date with the node resolution algorithm, but seems we dropped a few deep dependencies along the way too (which is good).you can see it caught a bug in one of our fixtures (missing package exports) which node's own algorithm would disallow (and enhanced-resolve does too)
in future i feel like this should actually just use
import.meta.resolve(path, base). however, that signature is only available behind a flag in node. I did also make a branch using the ponyfill (import-meta-resolveon npm) instead of this but it will refuse to import a directory from our ESM sources (rightly so) so the tests failif you'd prefer that, i'd be happy to push the branch