search

csswizardry / inuit.css

Powerful, scalable, Sass-based, BEM, OOCSS framework.
inuitcss.com
Other
3.83k stars 415 forks source link

Add a global flag on quote variables #304

Closed emagnier closed 10 years ago

emagnier commented 10 years ago

Sass 3.3 is now out. This PR fix the warning about declaring a scoped variable without the !global flag.

DEPRECATION WARNING on line 8 of base/_quotes.scss:
Assigning to global variable "$open-quote" by default is deprecated.
In future versions of Sass, this will create a new local variable.
If you want to assign to the global variable, use "$open-quote: \201C !global" instead.
Note that this will be incompatible with Sass 3.2.
benjaminreid commented 10 years ago

@csswizardry I know you said you weren't going to merge any PR's anymore but could you make an exception for this?

For people wanting to use this version of Inuit and for it to sit happily with Sass 3.3, this really should be accepted.