search

cstawitz / roomba

General purpose API response tidier
https://cstawitz.github.io/roomba/index.html
Other
138 stars 11 forks source link

prefix keep with purrr:: #73

Closed bfgray3 closed 6 years ago

bfgray3 commented 6 years ago

thanks for the cool package!

aedobbyn commented 6 years ago

Hey @bfgray3! Thanks for your PR. Confusingly, keep isn't actually purrr::keep, it's one of the functions any or all, which we grab with match.fun here.

The docs could definitely be more explicit about that. Appreciate your interest in the package, more than happy to merge in something that updates the docs or adds any features you think are missing!

bfgray3 commented 6 years ago

I see now--sorry for my confusion!

aedobbyn commented 6 years ago

All good!