Solar thermal parameters

cstb / citygml-energy

CityGML Energy ADE

43 stars 9 forks source link

Solar thermal parameters #134

Closed RomainNouvel closed 7 years ago

RomainNouvel commented 7 years ago

To be more comprehensible, we could replace the attribute names of SolarThermalSystem and PhotovoltaicThermalSystem: eta0 -> zero heat loss efficiency (scaletype[0.1]), also called optical efficiency a1 -> linear heat loss coefficient (numerical) a2 -> quadratic heat loss coefficient (numerical)

mlauster commented 7 years ago

@RomainNouvel, could you put that in a request of change? Than we can approve that.

RomainNouvel commented 7 years ago

Request of Change: Rename parameters of the class ThermalSolarSystem more explicitly:

eta0 -> opticalEfficiency (scaletype[0.1]). Def: corresponds to the zero heat loss efficiency. Generally noted eta0.
a1 -> linearHeatLossCoefficient (numerical). Def : Linear coefficient of the heat loss polynomial equation. Also noted a1.
a2 -> quadraticHeatLossCoefficient (numerical). Def : Quadratic coefficient of the heat loss polynomial equation. Also noted a2.