cstb / citygml-energy

CityGML Energy ADE
41 stars 9 forks source link

new Class RefurbishmentMeasures #42

Closed RomainNouvel closed 8 years ago

RomainNouvel commented 9 years ago

In the Energy ADE version 0.5, information concerning possible refurbishment measures are integrated inside the _AbstractBuilding Class as two attributes: yearOfRefurbishment[Year] and refurbishmentClass[CharacterString].

The present structure does not allow to have partial RefurbishmentMeasures (e.g. only for a wall, a window or a energy system), nor several RefurbishmentMeasures for one building. Moreover, yearOfRefurbishment might be too precise, and refurbishmentClass as CharacterString is not usable in software/libraries

PROPOSITIONS:

JoachimBenner commented 8 years ago

I agree in case a generally accepted CodeList for the levelOfRefurbishment is available.

PRemmen commented 8 years ago

agree with Joachim, for Germany we could for example add the different EnEV standards to this codelist

Fouly commented 8 years ago
RomainNouvel commented 8 years ago

Experience from practical use: RefurbishmentMeasures assigned to _Opening and EnergyConversionSystem make no sense, since someone has the detailed information, that a window, respectively a energy conversion system, has been exchanged, he will rather actualize the _Opening construction and the EnergyConversionSystem with the new ones, than use the class RefurbishmentMeasures...

For this reason, I would delete the attributes RefurbishmentMeasureOnOpening of the class _Opening and RefurbishmentMeasureOnEnergySystem of the class EnergyConversionSystem introduced at the end of last year.

oliviertournaire commented 8 years ago

Implemented in latest version of the UML model