search

cstb / citygml-energy

CityGML Energy ADE
41 stars 9 forks source link

Space-separated values in regular time series #63

Closed RomainNouvel closed 8 years ago

RomainNouvel commented 8 years ago

Make possible to store time series under the form of space separated values inside the same tag.

Proposition of Jerome, agreed by Joachim and Thomas.

RomainNouvel commented 8 years ago

Change the type of values (RegularTimeSeries) to MeasureList [1]. As a consequence: 1- remove the uom attribute from the TimeValuesProperties 2- introduce the uom attribute UnitOfMeasures in class IrregularTimeSeries [1].

JoachimBenner commented 8 years ago

I agree that we should model the values of a RegularTimeSeries as DoubleList. but I do not see the necessity to use a MeasureList. I think, all values in a single TimeSeries will have the same unit of measurement. So, what is the benefit of specifying 10.000 times a uom "m2", instead of specifying this value once in the DataType "TimeValueProperties"?

I would propose to make the property uom in TimeValueProperties mandatory. On the other hand, the text attributes qualityDescription and source should be optional.

RomainNouvel commented 8 years ago

Are you sure that we must indicate the unit of measure of each single value inside one MeasureList?

JoachimBenner commented 8 years ago

You are right, the umo is only specified once in a MeasureList. We should use MeasureList.