cstb / citygml-energy

CityGML Energy ADE
43 stars 9 forks source link

_SolarEnergySystem #91

Closed RomainNouvel closed 8 years ago

RomainNouvel commented 8 years ago

In the Energy ADE 0.6:

  1. the SolarEnergySystem present only the geometrical information "collectorSurface", "panelAzimuth" and "panelInclination", and not a given geometrical surface.
  2. Furthermore, it is linked only to BoundarySurface with an optional double relations: a) The "installedOn" relation from SolarEnergySystem to BoundarySurface is the mostly used case, where we want to calculate the photovoltaic electricity production of a given PV system, in particular to cover the electrical demand. This relation should be mandatory. b) The "equippedWith" relation from BoundarySurface to SolarEnergySystem has been originally designed for Photovoltaic Potential study, where the SolarEnergySystem is a floating object not related to an EnergyDemand. This relation could be avoid if the SolarEnergySystem is related in a way with a Building (which is possible with the relation "has" from AbstractBuilding to EnergyConversionSystem.
  3. The case of tilted PV panels on flat roof is not considered in our Schema (here, the SolarEnergySystem MUST be laid on a Roof/facade)
  4. The attribute area of SolarEnergySystem should be detailed (aperture area, module area, gross area?).
  5. The present schema does not allow to integrate Hybrid PVT panels

Propositions for Energy ADE 0.7:

RomainNouvel commented 8 years ago
mlauster commented 8 years ago

@jaykae26, can you comment on that and if @RomainNouvel made a good proposal, label this as ready for ADE Core?

gioagu commented 8 years ago

I am not so sure about adding a surfaceGeometry to the SolarEnergySystem. I understand and agree with the need, but I wonder whether it is the right approach. As a matter of fact, any SolarEnergySystem (installed on a building) is per definition already an outer BuildingInstallation. Therefore, it is already possible to model it geometrically (though from LoD2). As long as a SolarEnergySystem is a semantic object, ok, but so we may add a geometrical attribute to something that has already a geometry.

On the other hand: how would you model a solar panel that is not "mounted" on a building, e.g. like in solar power plant? So I agree that simply extending a BuildingInstallation would not suffice or cover all the cases.

JoachimBenner commented 8 years ago

I mostly agree with the proposal of Romain. The only exception is the topic

The relation "installedOn" from SolarEnergySystem to BoundarySurface, respectively BuildingInstallation, should have the cardinality 0..1 (if a Solar installation covers really several BoundarySurface, then it should be divided in several SolarEnergySystem).

In existing CityGML data, the division of e.g. a building wall or roof into WallSurface / RoofSurface objects is sometimes a little bit arbitrary. Thus, in some cases it might be difficult to divide a solar installation among different boundary surfaces. We should leave the cardinality 0..*, but add an (informal) restriction, that all referenced BoundarySurfaces must have the same orientation (azimuth and inclination).

We can make the _SolarEnergySystem attributes optional, but then we must clearly state that

Because the latter condition may not always be fulfilled, I thik we need an extra geometry property surfaceGeometry of _SolarEnergySystem

RomainNouvel commented 8 years ago

The original (and, I think, only) purpose of the relation "installedOn" is to get the solar irradiance (in W/m²) incoming on the BoundarySurface or BuildingInstallation on which the SolarEnergySystem is installed, in order to calculate ist Energy yield (based on the area of the solar System). Then, in the case that a Roof is divided in several small BoundarySurface with the same orientation, the incoming solar irradiance of all of them will be identical (unless if there is a very close obstruction object). Then, no need to have a cardinality 0..* of "installedOn" in this case, just mentioning that the "SolarEnergySystem" is "installedOn" the mostly covered BoundarySurface.

mlauster commented 8 years ago

@RomainNouvel, @JoachimBenner, is there an agreement on this? DOes core takes care of implementation?

RomainNouvel commented 8 years ago

Request of Change:

JoachimBenner commented 8 years ago

I made the following additional changes:

mlauster commented 8 years ago

Sounds good for me. @RomainNouvel, do you have something to add?

RomainNouvel commented 8 years ago

Hi Joachim, Ok for your reported changes. Do you plan to implement also the further requested changes of this issue in the new Energy ADE 0.7? Do you have some remarks about them?

oliviertournaire commented 8 years ago

Implemented in latest version of the UML model. @JoachimBenner Just a short comment: attributes a1, a2, apertureArea, collectorType and eta0 can be moved to an abstract class. Thus, SolarThermalSystem and PhotovoltaicThermalSystem would inherit this class (just a refactoring issue). Issue cand be reopened later based on this comment