search

cstefanache / angular2-img-cropper

Angular 2 Image Cropper
MIT License
364 stars 135 forks source link

Make package angular4 ready #147

Closed axtho closed 7 years ago

axtho commented 7 years ago

This should be as easy as bumping the versions to current. E.g. this one compiles just fine. Example App also works (with below exceptions). I also enabled the "strictNullChecks": true, in tsconfig.

package.json

"peerDependencies": {
    "@angular/common": ">=2.0.0 <5.0.0 || >=4.0.0-beta <5.0.0",
    "@angular/compiler": ">=2.0.0 <5.0.0 || >=4.0.0-beta <5.0.0",
    "@angular/core": ">=2.0.0 <5.0.0 || >=4.0.0-beta <5.0.0"
  },
  "devDependencies": {
    "@angular/common": "^4.0.0-rc.6",
    "@angular/compiler": "^4.0.0-rc.6",
    "@angular/core": "^4.0.0-rc.6",
    "@angular/forms": "^4.0.0-rc.6",
    "@angular/http": "^4.0.0-rc.6",
    "@angular/platform-browser": "^4.0.0-rc.6",
    "@angular/platform-browser-dynamic": "^4.0.0-rc.6",
    "angular-in-memory-web-api": "~0.2.4",
    "concurrently": "^3.4.0",
    "core-js": "^2.4.1",
    "es6-shim": "^0.35.1",
    "lite-server": "^2.2.2",
    "ng2-tabs": "0.0.7",
    "reflect-metadata": "^0.1.3",
    "rxjs": "^5.0.1",
    "zone.js": "^0.8.5",
    "systemjs": "0.19.27",
    "typescript": "^2.1.5",
    "typings": "^2.1.0",
    "version": "^0.1.2"
  },

some errors on running the example app

[1] node_modules/@angular/common/src/directives/ng_class.d.ts(48,34): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/aot/compiler.d.ts(48,32): error TS2304: Cannot find name 'Map'.
[1] node_modules/@angular/compiler/src/compile_metadata.d.ts(369,20): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/compile_metadata.d.ts(371,28): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/compile_metadata.d.ts(373,15): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/compile_metadata.d.ts(375,23): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/compile_metadata.d.ts(377,17): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/compile_metadata.d.ts(379,25): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/compiler/src/output/output_ast.d.ts(444,63): error TS2304: Cannot find name 'Set'.
[1] node_modules/@angular/core/src/change_detection/differs/default_keyvalue_differ.d.ts(23,15): error TS2304: Cannot find name 'Map'.
[1] node_modules/@angular/core/src/change_detection/differs/default_keyvalue_differ.d.ts(27,16): error TS2304: Cannot find name 'Map'.
cstefanache commented 7 years ago

Thanks!