cstefanache / angular2-img-cropper

Angular 2 Image Cropper
MIT License
364 stars 135 forks source link

remove ts files from npm package #148

Closed saithis closed 7 years ago

saithis commented 7 years ago

We have noUnusedLocals activated in our tsconfig.json and when we import the ng2-img-cropper our build fails. this is because tsc applies the noUnusedLocals rule to the ts files in your npm package, which has unused locals.

Could your please exclude the ts file from the npm package?

cstefanache commented 7 years ago

Fixed!

wnabil commented 7 years ago

version 0.8.3 also got same error but i can see the ts files i downgraded the module to 0.8.1 until the fix on 0.8.3

leosvelperez commented 7 years ago

@cstefanache I'm seeing this issue closed but I'm still facing the same issue. The distributable package on npm still has the .ts files, it should have only the .d.ts. Having the .ts files causes compilation problems due to different linter rules and tsconfig configurations. I tried removing the .ts manually from the package and then it worked my project compilation as it should be.