search

cstefanache / angular2-img-cropper

Angular 2 Image Cropper
MIT License
364 stars 135 forks source link

Change name to ngx-img-cropper #242

Closed aiqingyuyan closed 6 years ago

aiqingyuyan commented 6 years ago

therefore this project will be aligned with other Angular projects.

Do you agree?

abhishekdgeek commented 6 years ago

You mean this works fine with Angular (v4)?

aiqingyuyan commented 6 years ago

@abhishekdgeek I am using 4.1.3, and it works fine

mansura-habiba commented 6 years ago

I dont think this works fine with Angular 4 . As I found the following error while importing to a Angular4 project

Uncaught Error: Unexpected value 'ImageCropperComponent' declared by the module 'ProfileAppModule'. Please add a @Pipe/@Directive/@Component annotation. at syntaxError (compiler.es5.js:1694) at compiler.es5.js:15590 at Array.forEach () at CompileMetadataResolver.webpackJsonp.../../../compiler/@angular/compiler.es5.js.CompileMetadataResolver.getNgModuleMetadata (compiler.es5.js:15572) at JitCompiler.webpackJsonp.../../../compiler/@angular/compiler.es5.js.JitCompiler._loadModules (compiler.es5.js:26958) at JitCompiler.webpackJsonp.../../../compiler/@angular/compiler.es5.js.JitCompiler.compileModuleAndComponents (compiler.es5.js:26931) at JitCompiler.webpackJsonp.../../../compiler/@angular/compiler.es5.js.JitCompiler.compileModuleAsync (compiler.es5.js:26860) at PlatformRef.webpackJsonp.../../../core/@angular/core.es5.js.PlatformRef_.bootstrapModuleWithZone (core.es5.js:4536) at PlatformRef.webpackJsonp.../../../core/@angular/core.es5.js.PlatformRef_.bootstrapModule (core.es5.js:4522) at Object.../../../../../src/main.ts (main.ts:11)

jawandsingh commented 6 years ago

i am getting the same error. :(

web-dave commented 6 years ago

Angular 5 support has landed and i changed the name as well. this repo is deprecated. But this comp will be maintained by me at https://github.com/web-dave/ngx-img-cropper