search

cstefanache / angular2-img-cropper

Angular 2 Image Cropper
MIT License
364 stars 135 forks source link

update version to Angular 5 #268

Closed web-dave closed 6 years ago

web-dave commented 6 years ago

I used the version 0.7.6 with angular 5. only the version in the package.json should be updated.

jenshelderweirdt commented 6 years ago

It would be awesome if this PR could be merged...

kush-jain commented 6 years ago

@cstefanache @mounirrquiba Please check if it is possible for you guys to expedite this.

sketchthat commented 6 years ago

Is this project still maintained? Is anyone wanting to fork, build and deploy the latest changes to a new NPM package? I'm sure there are a lot of people keen to upgrade to NG5.

jenshelderweirdt commented 6 years ago

@cstefanache Are you still maintaining this project? Otherwise I'm willing to take over.

akhilesh2310 commented 6 years ago

Could you please merge this pr, we really need this update

sketchthat commented 6 years ago

@jenshelderweirdt I emailed @cstefanache and he's unable to maintain the project anymore but is happy to assign someone else admin. I'll put your name forward.

sketchthat commented 6 years ago

Bump.

Anyone interested in taking over?

zijianhuang commented 6 years ago

I am using NG 5.10 and cropper 0.8.8, so far so good except the front camera. If none of the active contributors like Andrew Rumm rayzru, I may be interested.

web-dave commented 6 years ago

I'm interested to take over.

jenshelderweirdt commented 6 years ago

Sorry guys, it really was a hell of month. @web-dave off you go.

web-dave commented 6 years ago

Thx @jenshelderweirdt. So I'm waiting for to get the write access to merge this PR, right?

web-dave commented 6 years ago

since we use thios in ur application with angular 5.x and i found no issue, i merge it.

sketchthat commented 6 years ago

@web-dave do you have access to update NPM as well? https://www.npmjs.com/package/ng2-img-cropper

web-dave commented 6 years ago

I'm not sure, I can check it on Wednesday.

web-dave commented 6 years ago

Didn't get a notification