search

cstefanache / angular2-img-cropper

Angular 2 Image Cropper
MIT License
364 stars 135 forks source link

Improve NGC compatibility #84

Closed cleever closed 7 years ago

cleever commented 8 years ago

On running ngc, there are a lot of errors with visibility and methods params.

This pull request change some inputs visibilities and fix the method params to match with the html call.

cstefanache commented 8 years ago

I will try to solve the conflict by tomorrow evening so we can merge it and create a new release at the end of the week

stewones commented 7 years ago

@cleever have you tried with Ionic?

iOS? thoughts?

I'm just looking for a workaround because I can't get cordova-plugin-crop working on iOS

cleever commented 7 years ago

@st1s for Ionic you should consider using Cropperjs as described in the ionic forum: https://forum.ionicframework.com/t/image-cropping-plugin/51206/27

ghost commented 7 years ago

@cleever I am using angular2-img-cropper with ionic with no problems.