search

csteinmetz1 / auraloss

Collection of audio-focused loss functions in PyTorch
Apache License 2.0
745 stars 67 forks source link

Moving librosa and scipy to optional install #37

Closed csteinmetz1 closed 1 year ago

csteinmetz1 commented 2 years ago

This could result in minor breaking changes for some users who are using melspectrogram-based losses or the FIR filter. However, this is likely a very small number of users and the there will be benefits to removing librosa which can cause issues on install on various platforms.

csteinmetz1 commented 2 years ago

Users who want the above functionality should be able to install librosa and scipy with pip install auraloss[all].

turian commented 2 years ago

@csteinmetz1 any idea when this might be live?

csteinmetz1 commented 2 years ago

Looking to take this into main shortly (hopefully 1 week).

turian commented 2 years ago

I might be wrong but do you also need to edit pyproject.toml?