search

csteinmetz1 / auraloss

Collection of audio-focused loss functions in PyTorch
Apache License 2.0
695 stars 66 forks source link

[WIP] Update precommit and workflows #39

Closed turian closed 1 year ago

turian commented 1 year ago

Updates

I have one that does flake8 and black, but I'm not sure you feel like fixing weird flake8 complaints.

Anyway, we can cherry pick the pieces of this that you like or just reject this entirely.

Notes + Questions

I see you have REQUIRES_PYTHON = ">=3.6.0". Python 3.6 is already EOL'ed since half a year ago but we can include 3.6 tests too.

Why does existing publish-to-test-pypi.yml only do Python 3.7?

Why are version numbers pinned in requirements but not setup.py?

I had to install libsndfile-dev to get tests to pass, perhaps that should go in the README? (I could make a PR if you like.)

turian commented 1 year ago

Hmm unfortunately I'm going to close this PR for now. There's a bit too much missing from the repo to run the tests standalone. e.g. the librimix data is not there but some of the tests use it. We could pull 600MB of minilibrimix from zenodo but that's a bit exaggerated.

For the e2e tests that take hours, those code be skipped, but it would be nice to have the tests/ run relatively quickly on a tiny dataset that could be checked into another git repo.

Anyway, I gave it the old college try :) This isn't really that important since the library is great, I was just having fun putzing around for an hour.