cstenkampstrahm / Aussie_project

0 stars 1 forks source link

Feedback on project draft #2

Open geanders opened 7 years ago

geanders commented 7 years ago

@cstenkampstrahm @bralex @Preston5789 : Since you're presenting so soon, I wanted to make sure I went ahead and got you some feedback on the current version of your project (based on the GitHub repository as of this evening). These are items for you to consider for your final draft of the project due next week, not things that you necessarily need to resolve by the time you present. Also, I don't expect you to incorporate all of the suggestions, but do address some of them. I think the only severe concern I had is that the RMarkdown document doesn't include any interesting R code-- all the figures are being generated with a script somewhere else and then read in as images. This keeps the file from being truly reproducible, as if I wanted to go back and see how you made a figure, I can't do that (I could find the image file you're reading in, but there's no way for me to figure out from that image file which R script was used to create it, so I'd have to search through all of your R scripts to find the right code). Once quick alternative is that you may be able to call source on the R scripts you're using to create the plots from within the RMarkdown document--- at least in that case the RMarkdown document would clearly specify which file has the code used for each figure, so it would be a bit more reproducible.

Here are other comments, split into comments for the RMarkdown report, the Shiny app, and overall:

RMarkdown document

Shiny App

Overall

bralex commented 7 years ago

The only reason there was an immediate follow-up commit was my embarrassment at that one… :)

On Dec 6, 2016, at 12:57 AM, Brooke Anderson notifications@github.com wrote:

• (PS: commit message for commit 81d53b2 is my favorite in this repository so far. Sometimes I feel that way too.) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.