Open geanders opened 7 years ago
The only reason there was an immediate follow-up commit was my embarrassment at that one… :)
On Dec 6, 2016, at 12:57 AM, Brooke Anderson notifications@github.com wrote:
• (PS: commit message for commit 81d53b2 is my favorite in this repository so far. Sometimes I feel that way too.) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@cstenkampstrahm @bralex @Preston5789 : Since you're presenting so soon, I wanted to make sure I went ahead and got you some feedback on the current version of your project (based on the GitHub repository as of this evening). These are items for you to consider for your final draft of the project due next week, not things that you necessarily need to resolve by the time you present. Also, I don't expect you to incorporate all of the suggestions, but do address some of them. I think the only severe concern I had is that the RMarkdown document doesn't include any interesting R code-- all the figures are being generated with a script somewhere else and then read in as images. This keeps the file from being truly reproducible, as if I wanted to go back and see how you made a figure, I can't do that (I could find the image file you're reading in, but there's no way for me to figure out from that image file which R script was used to create it, so I'd have to search through all of your R scripts to find the right code). Once quick alternative is that you may be able to call
source
on the R scripts you're using to create the plots from within the RMarkdown document--- at least in that case the RMarkdown document would clearly specify which file has the code used for each figure, so it would be a bit more reproducible.Here are other comments, split into comments for the RMarkdown report, the Shiny app, and overall:
RMarkdown document
map_data
(stamen I think, but not google), you can input a bounding box (latitude and longitude for the outside corners of the range) and clip the map right down to the area you need. See the helpfile?get_stamenmap
for some more details.large map
code chunk)?small map
code chunk)?largemap
instead oflarge map
). I think in some cases these code chunk names are treated as objects in R, so it’s safer to not have spaces.forcats
functions to arrange these by number of sample or average radionuclide (if that’s meaningful) or something.readxl
and write out a csv, if you want one, using R? This would allow you to script everything you did starting from the raw data you got from someone else.Mollusc
plot, you’ve got some overlap in points, so add some transparency to the points.Mollusc
plot, it would be very interesting to turn this into a two-panel plot. Use the left panel to show a map with all Mollusc samples, with radionuclide concentration shown by color of the point, and the other panel with this scatterplot. That would allow the reader to see a few things. First of all, are all the measurements that are clustered at the same distance actually from the same location, or did that sample in different locations along the radius of this distance from the mine (maybe it’s a distance relevant to policy or something)? Also, does direction from the mine matter? For a given distance, is the concentration usually higher north of the mine that south of it or something?scales = “free_y”
in thefacet_wrap
call. The difference in scales between the different metals makes it really hard to see any trends in AS. Also, transparency would be helpful for your points in this plot. I expect, for example, that all of the metals have lots of measurements just under 2 km, but you can only see that for Cu, because that’s the only metal for which there is much variation in the y variable across the samples. If you use some transparency, you could see where there are clumps of measurements, even if the measures don’t vary in y.Shiny App
server.R
file.sliderInput
with a two-unitvalue
input to do that (e.g.,value = c(1976, 2015)
). Set the default to be the full study period, so that when your app first opens, there will be lots of points. You’ll need to change the server file so you filter the data to years frominput$slider1[1]
toinput$slider1[2]
. You could also play around with including the option to put in an animation button for this widget (try using theanimate = TRUE
option insliderInput
).Overall
R
subdirectory (although why do you have a copy of the RMarkdown Word output there?). Same for thedata_raw
folder— great that you used this to store your raw data. It was immediately clear to me in looking through your directory which files contained your original data.