codecov-commenter
commented
1 year ago Codecov Report
Patch coverage has no change and project coverage change: -1.19 :warning:
Comparison is base (
85eaadf) 69.01% compared to head (2f047a1) 67.82%.:exclamation: Current head 2f047a1 differs from pull request most recent head 7a7bdd6. Consider uploading reports for the commit 7a7bdd6 to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #126 +/- ## ========================================== - Coverage 69.01% 67.82% -1.19% ========================================== Files 14 14 Lines 781 774 -7 ========================================== - Hits 539 525 -14 - Misses 242 249 +7 ``` | [Impacted Files](https://app.codecov.io/gh/cstjean/ScikitLearn.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/Skcore.jl](https://app.codecov.io/gh/cstjean/ScikitLearn.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL1NrY29yZS5qbA==) | `69.89% <ø> (-8.11%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/cstjean/ScikitLearn.jl/pull/126/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
tylerjthomas9
cstjean
Ref https://github.com/cstjean/ScikitLearn.jl/issues/125
When libstdcxx is not one of the compatible versions, avoid trying to install
libstdcxx-ngnothing. This will cause the user to have to make sure the library is compatible if their libstdcxx version is not in the mapping. I think eventually we can remove this mapping, but the current LTS version of Julia doesn't work with recent scikit-learn versions, so it should hopefully solve any headaches from this.