search

cstjean / ScikitLearn.jl

Julia implementation of the scikit-learn API https://cstjean.github.io/ScikitLearn.jl/dev/
Other
546 stars 75 forks source link

Compatibility with 0.7 #43

Closed theogf closed 5 years ago

theogf commented 6 years ago

Hello,

Would it be possible to update the code to make it compatible with Julia 0.7? When I try to compile it I get

ERROR: LoadError: LoadError: LoadError: LoadError: type QuoteNode has no field args
Stacktrace:
 [1] getproperty(::Any, ::Symbol) at ./sysimg.jl:18
 [2] @delegate(::LineNumberNode, ::Module, ::Any, ::Any) at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/sk_utils.jl:73
 [3] include at ./boot.jl:317 [inlined]
 [4] include_relative(::Module, ::String) at ./loading.jl:1038
 [5] include at ./sysimg.jl:29 [inlined]
 [6] include(::String) at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/Skcore.jl:5
 [7] top-level scope at none:0
 [8] include at ./boot.jl:317 [inlined]
 [9] include_relative(::Module, ::String) at ./loading.jl:1038
 [10] include at ./sysimg.jl:29 [inlined]
 [11] include(::String) at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/ScikitLearn.jl:10
 [12] top-level scope at none:0
 [13] include at ./boot.jl:317 [inlined]
 [14] include_relative(::Module, ::String) at ./loading.jl:1038
 [15] include(::Module, ::String) at ./sysimg.jl:29
 [16] top-level scope at none:2
 [17] eval at ./boot.jl:319 [inlined]
 [18] eval(::Expr) at ./client.jl:399
 [19] top-level scope at ./none:3
in expression starting at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/sk_utils.jl:236
in expression starting at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/sk_utils.jl:236
in expression starting at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/Skcore.jl:13
in expression starting at /home/theo/.julia/packages/ScikitLearn/ILHSi/src/ScikitLearn.jl:12
ERROR: Failed to precompile ScikitLearn [3646fa90-6ef7-5e7e-9f22-8aca16db6324] to /home/theo/.julia/compiled/v0.7/ScikitLearn/tbUuI.ji.
cstjean commented 6 years ago

Yes! I'd like to get to it before the end of the week.

cstjean commented 6 years ago

Some progress: the current master no longer errors upon using, but I'm not sure when I'll have the time to push it further (still lots of warnings). Feel free to post issues for any bug you encounter.