cstjean / ScikitLearn.jl

Julia implementation of the scikit-learn API https://cstjean.github.io/ScikitLearn.jl/dev/
Other
546 stars 75 forks source link

Current Arch python-sklearn invalid version string #68

Closed aquaresima closed 4 years ago

aquaresima commented 4 years ago

Hi, I am running 4.19.107-1-MANJARO, current binaries of SKlearn are python-scikit-learn 0.22.2.post1-1

when I run using ScikitLearn @sk_import naive_bayes: GaussianNB

I get: ERROR: ArgumentError: invalid version string: 0.22.2.post1 Stacktrace: [1] VersionNumber(::String) at ./version.jl:111 [2] import_sklearn() at /home/cocconat/.julia/packages/ScikitLearn/bo2Pt/src/Skcore.jl:120 [3] top-level scope at /home/cocconat/.julia/packages/ScikitLearn/bo2Pt/src/Skcore.jl:153

I solved hardcoding the version in \usr\lib....\sklearn_init_.py and removig '.post1'. Please fix it

Best

cstjean commented 4 years ago

Thank you for the report. It's a dup of #67 , but if that's what's installed in some distros, we should indeed fix it. This code is just to send a warning, so we could wrap it in try/catch to ignore the error. Would you like to make a PR?