search

cstjean / ScikitLearn.jl

Julia implementation of the scikit-learn API https://cstjean.github.io/ScikitLearn.jl/dev/
Other
546 stars 75 forks source link

Update Project.toml #69

Closed OkonSamuel closed 4 years ago

OkonSamuel commented 4 years ago

This PR updates the projects Project.toml file and adds compat section for compatibility with Julia 1 and Julia 1.4. It also fixes some deprecations. Compatibility with Julia 0.7 is no longer supported.

cstjean commented 4 years ago

Thanks a lot! Do you know why the tests didn't run? I also had that on my other package.

cstjean commented 4 years ago

Still no CI triggered 😢 Should I merge anyway? Can you run the tests locally?

OkonSamuel commented 4 years ago

Still no CI triggered 😢 Should I merge anyway? Can you run the tests locally?

The tests are running but they aren't showing under the github repo. Check your travisci repo page. The build is failing there. I think its not showing probably to a github authentication issue. see issue

OkonSamuel commented 4 years ago

@cstjean Still hold off on the merging.

OkonSamuel commented 4 years ago

Still no CI triggered 😢 Should I merge anyway? Can you run the tests locally?

The tests are running but they aren't showing under the github repo. Check your travisci repo page. The build is failing there. I think its not showing probably to a github authentication issue. see issue

@cstjean. Have to tried the recommendation on the github issue.

cstjean commented 4 years ago

Will do when I find some time. I'll be unavailable for the next few days. Feel free to merge when you're satisfied with your PR.

OkonSamuel commented 4 years ago

@cstjean. Yea. The build is now showing as github checks

alexmorley commented 4 years ago

:shipit: