search

cstjean / ScikitLearn.jl

Julia implementation of the scikit-learn API https://cstjean.github.io/ScikitLearn.jl/dev/
Other
547 stars 75 forks source link

Consider removing dependency over downstream packages #80

Closed cstjean closed 4 years ago

cstjean commented 4 years ago

My idea for ScikitLearn.jl at the start was that each package would implement the ScikitLearnBase.jl interface, so that ScikitLearn.jl users wouldn't have everything installed. This is not true anymore with the DecisionTree / GaussianProcesses / ... dependencies.

@OkonSamuel Did you have a specific reason for putting them in the Project.toml? I'm not necessarily against it, but I think it should be discussed at least.

OkonSamuel commented 4 years ago

@OkonSamuel Did you have a specific reason for putting them in the Project.toml? I'm not necessarily against it, but I think it should be discussed at least.

It's for those notebooks i think. I'll look into it.

cstjean commented 4 years ago

Perhaps it would be sufficient to add a # install with ]add GaussianProcesses comment to those notebooks?