search

csu-hmc / perturbed-data-paper

A paper on an elaborate gait data set.
https://peerj.com/articles/918/
10 stars 6 forks source link

Suggest to remove one line from frequency analysis code #101

Closed tvdbogert closed 9 years ago

tvdbogert commented 9 years ago

@spinningplates

This line:

time_input=0:0.0033:round(input_signals(end,1));

You have already obtained the time stamps from column 1 of the input file, so recalculating these here seems unnecessary. I don't think it will change the results. Just to avoid confusion it may be good to remove this line.

skhnat commented 9 years ago

Yes, that seemed a little redundant, but in the original time stamps of column 1 of the input file, there are repeated values and the interp1 function reported an error because of that. Is there a different work around for this?

tvdbogert commented 9 years ago

Your workaround is fine,maybe just add a comment in the code to explain. I don't think the repeated time stamps had an effect on what we did (assuming it did not confuse D-Flow's interpolation). The temporal resolution is still 0.01 s which is plenty.