search

csu-hmc / perturbed-data-paper

A paper on an elaborate gait data set.
https://peerj.com/articles/918/
11 stars 6 forks source link

Make sure YAML files include all of the data limitations #134

Closed moorepants closed 9 years ago

moorepants commented 9 years ago

Reviewer 3 (Srinivasan):

pages 16-17. I especially liked the ‘Data Limitations’ section. But I would suggest that all of these limitations be included as part of the meta data in the corresponding YAML files. For instance, in lines 378-381, you state that the force measurements should not be trusted in trials 6-15. I checked the YAML file for trial 6 and 15 (T006 and T015) to see if its ‘notes’ contained the same note, and it did not (unless I missed something). I think this would be very useful. Of course, I do see that other types of limitations or explanations are in the ‘notes’ section of the YAML file.

moorepants commented 9 years ago

The README which is included with both of the zipped data files includes the data limitation notes. I'd prefer to just leave the data as is and not add new notes to the YAML file. If I were to add these notes it seems the only thing worth adding would be "Use ground reaction loads with extreme caution or not at all." for trials 6-8 and "The ground reaction loads are corrupt due to the wooden support blocks. Do not use them." for trials 9-15.

If I add in the data from #105 into the data files then I can add this note, but I make the data from #105 a separate download then I should leave everything is. I'm just not too keen on making a new version of the data files.

moorepants commented 9 years ago

I am not going to fix this one.