search

csu / export-saved-reddit

Export saved Reddit posts into a HTML file for import into Google Chrome.
Other
433 stars 35 forks source link

Text files should not be opened in binary mode #40

Closed MuminKhan closed 7 years ago

MuminKhan commented 7 years ago

Fixes TypeError: 'str' does not support the buffer interface

codecov-io commented 7 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         136    136           
=====================================
  Hits          136    136
Impacted Files Coverage Δ
export_saved.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8277d77...f0b6d76. Read the comment docs.

rachmadaniHaryono commented 7 years ago

hi @MK3GTX, the binary mode is used to fix this issue #36

the #38 actually try to fix this as well and trying to give both mode used (binary and non binary mode)

csu commented 7 years ago

I just merged #38. Let's see if that fixes things.