csuermann / node-red-contrib-suncron

Node-RED node that triggers configurable outgoing messages based on the position of the sun
MIT License
9 stars 1 forks source link

Offset value in the example? #25

Closed mweissen closed 2 years ago

mweissen commented 2 years ago

There is the following example in the description:

{
  "sunrise": {
      "event": "sunrise",
      "sunEventTime": "2019-09-08T06:29:51",
      "cronTime": "2019-09-08T07:31:51",
      "offset": 0
  },
  "sunriseEnd": {
      "event": "sunriseEnd",
      "sunEventTime": "2019-09-08T06:33:24",
      "cronTime": "2019-09-08T03:33:24",
      "offset": 3600
  },
  "dawn": {
      "event": "dawn",
      "sunEventTime": "2019-09-08T05:54:49",
      "cronTime": "2019-09-08T06:54:49",
      "offset": -600
  }
  //...
}

I think the difference between the "eventTime" and the "cronTime" should be equal to "offset". Or have I misunderstood something?

csuermann commented 2 years ago

Hi @mweissen,

Good catch, thank you!

Fixed in v1.6.2