close out the "annotated" User one way or another

csufmse / student_information_system

2 stars 0 forks source link

close out the "annotated" User one way or another #328

Open bjmckenz opened 3 years ago

bjmckenz commented 3 years ago

still needed? either do it right as a manager or kill it.

bjmckenz commented 3 years ago

Testing:

no external visibiliy, but do make sure that "Admin" doesn't show up in Users table.

liannadevries09 commented 3 years ago

@bjmckenz - Admins are showing in the User Tables. I wasnt sure if you meant in schooladmin or in siteadmin but they appear in both. I would think that the system would need to show these users in that table incase they get fired and need to be removed?

bjmckenz commented 3 years ago

nope, this is the good admin. "admin" is the bad admin :-)

liannadevries09 commented 3 years ago

See notes in this ticket: https://github.com/csufmse/student_information_system/issues/337

bjmckenz commented 3 years ago

can we close out this one and keep #337 open? The code has been removed -- that's the goal here.