search

csukuangfj / kaldifeat

Kaldi-compatible online & offline feature extraction with PyTorch, supporting CUDA, batch processing, chunk processing, and autograd - Provide C++ & Python API
https://csukuangfj.github.io/kaldifeat
Other
186 stars 35 forks source link

C++ 17 needed with torch 2.1 #80

Closed yuekaizhang closed 10 months ago

yuekaizhang commented 10 months ago

Seems that Pytorch 2.1 (current default version) compiled with C++ 17. So, https://github.com/csukuangfj/kaldifeat/blob/master/CMakeLists.txt#L35 this line may need to change to 17, otherwise, we can't install it from source.

Error: C++17 or later compatible compiler is required

csukuangfj commented 10 months ago

Please see https://github.com/csukuangfj/kaldifeat/pull/81

yuekaizhang commented 10 months ago

Thanks, but how do you fix it in 20 mins :D

csukuangfj commented 10 months ago

Thanks, but how do you fix it in 20 mins :D

It has been fixed last week.

You can find pre-build wheels for torch 2.1 at https://csukuangfj.github.io/kaldifeat/cuda.html

pzelasko commented 7 months ago

It seems to still pop up, I'm adding python 3.12 and updating torch versions in Lhotse CI, unfortunately some configurations can't build, e.g.: https://github.com/lhotse-speech/lhotse/actions/runs/7888121954/job/21524871882?pr=1288

csukuangfj commented 7 months ago

It seems to still pop up, I'm adding python 3.12 and updating torch versions in Lhotse CI, unfortunately some configurations can't build, e.g.: https://github.com/lhotse-speech/lhotse/actions/runs/7888121954/job/21524871882?pr=1288

please use https://csukuangfj.github.io/kaldifeat/installation/from_wheels.html to install kaldifeat.