search

csukuangfj / optimized_transducer

Memory efficient transducer loss computation
Other
68 stars 11 forks source link

Update transducer-loss.h #19

Closed shanguanma closed 2 years ago

shanguanma commented 2 years ago

I found that https://github.com/csukuangfj/optimized_transducer/blob/0c75a5712f709024165fe62360dd25905cca8c68/optimized_transducer/csrc/transducer-loss.h#L17 and https://github.com/csukuangfj/optimized_transducer/blob/0c75a5712f709024165fe62360dd25905cca8c68/optimized_transducer/python/tests/test_compute_transducer_loss.py#L61 were not Inconsistent. I think that the front was not correct. Here I fixed it. @csukuangfj , what do you think?

csukuangfj commented 2 years ago

Thanks. I am using max_U and max_U_p1, Could you change U - 1 to max_U? (p1 means plus 1)

csukuangfj commented 2 years ago

Thanks!