search

csun-comp430-s24 / RefRaff

The programming language RefRaff supports structs and reference counted memory management.
2 stars 0 forks source link

Typechecker matt #20

Closed rgilyard closed 7 months ago

rgilyard commented 7 months ago

This all looks great!

I definitely agree about the struct def parameter scoping.

I didn't see how you were keeping track of all the struct def params, so I was redoing it worse, haha. Sorry about that.

I'll be visiting family for the week, so I won't be bothering you with more changes for a couple days : )

MattSmith6 commented 7 months ago

Oh wow, I'm really sorry! I had checked the list of tasks and both the struct allocations and dot expression weren't taken when I started to work on them. I did make sure to strikethrough them on the list, although I didn't ping. I do understand that I said that I wasn't going to work over break, so that probably did not help at all. It looks like we even pushed within a couple minutes of each other :/ I'm truly sorry about that, that's a lot of effort that's gone.

I think I'll go ahead and step back a little bit and give you more free range to work on whatever you would like for the typechecker, since the situation absolutely sucks! Feel free to take whatever you would like whenever you're next free to work on the project. I hope enjoy your time with family!

I will go back and add some stuff to the tokenizer and parser for more detailed error messages. Mainly, this will just be to store the line/column information. I have a feeling that by the end of the typechecker/code generator, we'd like to see more detailed error messages when creating test programs. It'll help us either debug our RefRaff code more easily (if we made a programming mistake), or identify any issues in our compiler by the end of the process (if there's any remaining bugs).

rgilyard commented 7 months ago

No! I wasn't being passive aggressive, I swear! I did some wild stuff for keeping track of the struct params. It was overkill and I didn't see that you were already keeping track of the struct params in a simpler, better way!

I felt bad because I thought I wasn't letting you enjoy your vacation with all the notifications : D

I don't consider it wasted effort at all - it makes me understand it better. Work on the typechecker all you want!

MattSmith6 commented 7 months ago

I didn't think you were being passive aggressive at all, just thought it was a bit sad that we both ended up working on the same thing :( I'm glad you're not upset by it, though! As for ruining my vacation, you're not lol. I knew I'd end up working on it anyways but have tried to limit myself a bit. It's a fun project!

I did a bit of work to add some more detailed error messages (and it was something I was interested in doing beforehand). I think it would be great for you to get the first pick of whatever is left for the typechecker, since again, you worked on something at the same time and we ended up using my version of it.