search

csutils / csmock

A tool for static analysis, dynamic analysis, and formal verification of RPM packages
GNU General Public License v3.0
23 stars 20 forks source link

csmock: use `NOCHECK_RPM_OPTS` also for `%build` #176

Closed kdudka closed 3 months ago

kdudka commented 3 months ago

... when execution of tests is not needed for the requested scan. This fixes an unnecessary failure while SAST scanning jss-4.9.4-1.module+el8.7.0+15532+95bac9ee

Resolves: https://issues.redhat.com/browse/OSH-697 Closes: https://github.com/csutils/csmock/pull/176

jperezdealgaba commented 3 months ago

Hey @kdudka , Regarding https://github.com/csutils/csmock/pull/175 , I assume these changes also take in consideration that if the tests are not in %build will also NOCHECK_RPM_OPTS be used , right?

kdudka commented 3 months ago

@jperezdealgaba Yes, the options will always be used for %build unless a csmock plug-in (e.g. valgrind) requires tests to run or a user explicitly asks to run them via --run-check.

jperezdealgaba commented 3 months ago

Thanks! That solves my doubt. /LGTM

kdudka commented 3 months ago

@jperezdealgaba Thanks for review!