There's a small con with GitHub Actions in this project: workflow runs on PRs from forked repositories do not get access to the repository's secrets (RAILS_MASTER_KEY, because this can be a vulnerability), and thus some tests that depend on having these will fail (mail_alias_sync_job_spec.rb and markdown_helper_spec.rb). Maybe in the future we can wind up a temporary camo container just for testing to not need the production secret for that anymore, but for the ImprovMX secret I cannot think of a good solution.
Because of above reason, this PR's workflows also fail 😅
Summary
This project's equivalent of https://github.com/csvalpha/amber-ui/pull/377!
There's a small con with GitHub Actions in this project: workflow runs on PRs from forked repositories do not get access to the repository's secrets (
RAILS_MASTER_KEY, because this can be a vulnerability), and thus some tests that depend on having these will fail (mail_alias_sync_job_spec.rbandmarkdown_helper_spec.rb). Maybe in the future we can wind up a temporary camo container just for testing to not need the production secret for that anymore, but for the ImprovMX secret I cannot think of a good solution.Because of above reason, this PR's workflows also fail 😅
Related: https://github.com/csvalpha/ELISA/issues/13