search

csvalpha / amber-ui

https://csvalpha.nl
MIT License
4 stars 4 forks source link

Dark theme #175

Open guidojw opened 4 years ago

guidojw commented 4 years ago

In order to save our precious eyes I thought it would be nice if we had our very own dark mode. I've been looking into Ember addons for dark mode and found there's already a very useful addon for this (ember-theme-changer).

Matthijsy commented 4 years ago

You can probably create 2 variables.scss (I believe the file is called that way) and change the values there for dark/light mode. Could be fancy to have

Op di 23 jun. 2020 om 19:25 schreef Guido de Jong <notifications@github.com

:

In order to save our precious eyes I thought it would be nice if we had our very own dark mode. I've been looking into Ember addons for dark mode and found there's already a very useful addon for this (ember-theme-changer).

I was wondering if our branding allows this? If it does I would be more than happy to further look into this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/csvalpha/amber-ui/issues/175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIOQZDMY5F7GZUINUQSNODRYDQO5ANCNFSM4OF4DDZA .

guidojw commented 4 years ago

The variables are all very specific and I don't think changing them would make sense in this case (for example making $white black may probably result in unexpected looks).

I saw that all color properties are defined in the style/components and style/modules directories and think that making a new style/themes directory with a directory per theme where (only) all color properties live will make the most sense.

I've slightly started on this and will commit soon