search

csvalpha / amber-ui

https://csvalpha.nl
MIT License
4 stars 4 forks source link

Added room adverts #804

Open Ellen-Wittingen opened 10 months ago

Ellen-Wittingen commented 10 months ago

Added room adverts. They are accessible via http://localhost:4200/room-adverts and via the menu-item in the left sidebar.

There is also a view for unauthorized users on the public part of the website, it is accessible via http://localhost:4200/public/room-forum and via the menu-item "Kamerforum" in the "Over ons" dropdown.

Please also check if the English translations are proper English, as nobody except from me has looked at them so far.

Note: it requires the following amber-api branch to function properly: https://github.com/csvalpha/amber-api/pull/393

DrumsnChocolate commented 1 month ago

The text can become rather long, and the text is not vertically bounded in display: afbeelding

DrumsnChocolate commented 1 month ago

afbeelding When logged in, I don't see any shorttext preview of the written content of the advert. Is this something we should add?

DrumsnChocolate commented 1 month ago

These are the main UX points I found. I will leave a code review later, this Friday evening probably

Ellen-Wittingen commented 1 month ago

Fixed the long scrolling content. Now there is a "lees meer" button that opens a modal with a scrollable bigger view of the advert when clicked upon. That modal is also opened when clicking anywhere on the advert.

image

image

Ellen-Wittingen commented 1 month ago

Fixed not showing a short description on room advert index page:

image