Add feature of tagging users in photos

[wilco375]

Summary

Add ability to tag other users. Related to #538, however tagging is still manual for now. As Elise mentioned in her mail, might be a good SOG activity to tag people.

When clicking on the image, you can tag a user: Tagged users are shown after adding a user or clicking the button at the top-right: In the user's profile, you can see all images in which the user is tagged:

You can only delete tags that you have created or which tag you (i.e. remove tags which incorrectly tag you)

Requires: https://github.com/csvalpha/amber-api/pull/415

[DrumsnChocolate]

I'm sorry I have not had time to look at this yet. Do you know if this works well on mobile?

[wilco375]

I'm sorry I have not had time to look at this yet. Do you know if this works well on mobile?

It's not great if there are a lot of people in the picture or near the edge, but it does work. Tagging is most easily performed on a desktop device.

[DrumsnChocolate]

Okay, testing this feature leads to the following comments:

• I'd like the input box to disappear when I press escape without selecting a name, or when I click next to the picture. On mobile, when the input box is visible, clicking anywhere next to the input box should hide the input box (instead of moving the input box to a new place).
• Leaving the route (or changing the route parameters) should hide the input box.
• I like that you place the input box exactly where the click is placed, but this may take a bit of getting used to for users. It is easiest for us to implement, and allows the user full control over where the tag is placed. Control is not necessarily the same as ease of use, since you kind of want the tag to be placed slightly offset from the thing you're tagging, but it's a good compromise. A possible improvement would be making the input box draggable, but that's definitely overengineering.
• the input box can appear in front of the button that reveals existing tags. This might not be optimal (unless it's easy to hide the input box, see first remark.)
• Can we make tags link to the profile of the tagged person? Such that we can easily navigate from a picture to the users tagged in the picture?
• I can imagine people who don't want to be tagged in pictures at all. Should we add a 'privacy' setting that enables a user to exclude themselves from the list of taggable people?

code related comments will follow later, either Monday evening or Friday evening

[wilco375]

Thanks Matteo.

• I have adjusted the code so that the tag box is hidden when clicking outside it or leaving the route. I could not get the escape key working unfortunately.
• Leaving the route should have already hidden the input box since the component is then no longer rendered. This seems to be working for me. Did you have any problems with that?
• I am failing to understand if you want anything changed on the behavior / methodology of the tagging 😅
• It's now easier to hide.
• Added. I linked to the overview of tagged photos
• Personally I feel like this isn't necessary, but I'd like to hear the opinion of other committee members on this.