search

cswendrowski / FoundryVTT-Custom-CSS

Allows a user to setup custom CSS rules in a FoundryVTT world
GNU General Public License v3.0
11 stars 9 forks source link

World level styles should be editable by any user with the appropriate permissions, not just the GM #15

Open mkahvi opened 2 years ago

mkahvi commented 2 years ago

Patch notes say

in addition to the global styles defined by the GM.

But these are not actually possible. Though they are still applied from old settings.

zeel01 commented 2 years ago

Could you give a bit more detail? Are you unable to edit the global styles? Is the settings form not working correctly? Are changes not being saved? Are there errors in the console?

mkahvi commented 2 years ago

Oh, I see, it's hidden in client-side setting for GM.

Well, the problem is that user with permissions to edit world settings (not assistant GM, just sufficient permissions) can not edit the global styles.

I initially thought it was just missing it from the module settings entirely.

Edit: That is, user that passes game.user.hasPermission("SETTINGS_MODIFY") test should be able to edit the global styling.

zeel01 commented 2 years ago

Edit: That is, user that passes game.user.hasPermission("SETTINGS_MODIFY") test should be able to edit the global styling.

Fair point.