cswendrowski / FoundryVTT-Custom-CSS

Allows a user to setup custom CSS rules in a FoundryVTT world
GNU General Public License v3.0
11 stars 9 forks source link

v11 Compatibility Check #20

Open brunocalado opened 1 year ago

brunocalado commented 1 year ago

Firstly, I would like to express my gratitude for your valuable contribution in developing this module for Foundry VTT. It has greatly enhanced my gaming experience.

I am reaching out to kindly request an update for your module to be compatible with the latest version of Foundry VTT, v11. As a passionate user of both Foundry VTT and your module, I am eagerly looking forward to enjoying the new features and improvements introduced in the latest version.

I understand that updating a module can be a time-consuming process, and I genuinely appreciate your effort and dedication in maintaining and improving it. Your work is highly valued by the Foundry VTT community.

If there is anything I can do to support you in this update process, such as providing feedback, testing, or any other assistance, please do not hesitate to let me know. I am more than willing to contribute to the success of your module.

Thank you for considering my request. I truly believe that updating your module to Foundry VTT v11 will greatly benefit the community and enhance the overall gaming experience for users. I am eagerly looking forward to the updated version.

zeel01 commented 1 year ago

Hey there Bruno, as you know many of us have a lot of time commitments outside of this hobby, and often that makes it difficult to find time to validate each module and update it to a new version. I think most authors, myself included, intend to update to each new release but few of us have the time to do so immediately. We don't have any influence on when core updates come, so sometimes they happen at inopportune times when we can't devote much attention.

Generally speaking, it's not necessary to request an update - the dev either knows there is an update needed and is working on it, or they're no longer interested in updating at all. In the first case, the most helpful thing any user can do is test the module on the new version, and report what issues they run into. Some modules probably just need an update to their manifest compatibility field, while others will need a lot of fixing. Reporting issues makes that process a bit easier, and allows devs to prioritize.

I think it's important that I also point out that requesting an update can have a somewhat counter-productive effect. Many times devs feel intimidated by the scope of work required to get all their packages updated - users reminding them and asking for updates generally only exacerbates this. Normally, I wouldn't bother mentioning this. However it has come to my attention that you have posted at least 11 copies of identical tickets on 11 different module repos - 3 of which were repos for which I am a maintainer.

This is not an approach I would recommend. While the text of the messages is very positive and flattering, it falls flat in a few way: First it comes across somewhat disingenuous when you say the same thing to... everyone, and don't actually mention the module by name, or anything it does. Second, while the text recognizes many of the challenges involved this doesn't negate the fact that making an "update request" is as I mentioned previously largely unnecessary and at times frustrating for developers. Finally, there doesn't appear to have been any attempt to test the modules in question or provide specific feedback that would assist the developer in expediting the update.

For this module for instance, I don't expect there to really be any issues. But I don't know, as I haven't had to time to install the update and test it yet. If a third party told me "hey, it's all good" I would probably just update the compat flag and be good to go. As it is, nobody has tested yet - which is fine - so I'll get to it when I get to it. But it does feel a little presumptuous when someone asks for an update without indicating whether or not they tested it and had a problem.