search

csyhuang / hn2016_falwa

Python library for computing Finite-Amplitude Local Wave Activity Diagnostics from climate data.
https://hn2016-falwa.readthedocs.io/en/latest/
MIT License
32 stars 16 forks source link

Add pyproject.toml #73

Closed chpolste closed 2 months ago

chpolste commented 1 year ago

Python appears to be moving away from the setup.py, so in the attached commit I tried to convert the setup.py to a pyproject.toml. I can get the package to install (incl. the .so files) locally, but it's my first time writing one so something will probably be missing or not properly configured. In particular, I haven't figured out how to compile extensions outside of setup.py and how to set development dependencies so they are picked up by the CI.

We could iterate in this PR to figure these issues out.

csyhuang commented 1 year ago

Hi Christopher, thanks for submitting this pull request. I haven't got time to research into methods for compiling f2py with this adjustment yet, so let's do this in a future release. Let's keep this PR active.

chpolste commented 12 months ago

This stackoverflow post is quite informative about compiling extensions with a pyproject.toml. It suggests that keeping a setup.py around for building extensions is part of the process. The setuptools docs seem to suggest the same.

I'll revisit this pull request in time for the 0.7.3 release.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (90ed657) 68.96% compared to head (92c500b) 70.21%. Report is 50 commits behind head on master.

Files Patch % Lines
falwa/xarrayinterface.py 95.45% 6 Missing :warning:
falwa/wrapper.py 0.00% 2 Missing :warning:
falwa/oopinterface.py 97.43% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #73 +/- ## ========================================== + Coverage 68.96% 70.21% +1.25% ========================================== Files 10 10 Lines 1060 1118 +58 ========================================== + Hits 731 785 +54 - Misses 329 333 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

csyhuang commented 9 months ago

@chpolste Sorry I accidentally deleted release1.0 branch such that this ticket is automatically closed. I have updated the branch pyproject-toml and wonder if this PR can be reopen?

Update: the issue has been resolved after I created a branch of the same name from master.