csyonghe / Spire

Other
174 stars 22 forks source link

Diagnostics #56

Closed tangent-vector closed 7 years ago

tangent-vector commented 7 years ago

Note: this PR builds on the hello-fix PR, so the diffs may be a little bit harder to follow until that gets merged.

This PR contains two changes to how diagnostic messages are generated/handled. The first changes core implementation stuff to streamline things around a single array of diagnostics, rather than separate error/warning arrays. The second change adapts the outward-facing API so that diagnostics can be captured/queried separately from a particular SpireComplationResult.