search

ct-Open-Source / Basecamp

An Arduino library to ease the use of the ESP32 in IoT projects
GNU General Public License v3.0
254 stars 48 forks source link

Boolean value inconsistencies in the configuration #58

Open tobiasisenberg opened 6 years ago

tobiasisenberg commented 6 years ago

I noticed that Boolean values for various configuration settings are used quite inconsistently. For example, config.set("OTAActive", "false"); does not work with "False", yet config.set("WifiConfigured", "True"); does not work with "true" since string comparisons are used. It would be great if Basecamp could be updated such that all versions are accepted, by using a string comparison that ignores the case of the strings. That would ensure backward compatibility.