search

ct-Open-Source / Basecamp

An Arduino library to ease the use of the ESP32 in IoT projects
GNU General Public License v3.0
254 stars 48 forks source link

Various small changes #66

Closed kolbyjack closed 5 years ago

kolbyjack commented 5 years ago

I'm not using Basecamp anymore, but figured you may want to take these changes

tobiasisenberg commented 5 years ago

Any reason that this was reverted? At the very least the "Ignore case of true/false values" makes a lot of sense and does not seem to do any harm, and I also don't see the "Allow setting custom AP name" to break anything. The "Add ConfigurationKey entries for other predefined keys" may be more tricky, but at least for the other two it would be nice if they would be merged.