Open pdugas opened 3 years ago
Fantastic. This works great!
I hate that my Python userland is too new to do this natively. I love that I can just download a new userland and play in that :)
Edit: You may want to add iproute2
and grep
to the apk add
. Looks like busybox grep has no -P
erl.
Head's up... The check_port
logic in setup-checks.sh
won't work when running in a container like this. You will need to ensure the corresponding local services are disabled on the host machine yourself.
Head's up... The
check_port
logic insetup-checks.sh
won't work when running in a container like this. You will need to ensure the corresponding local services are disabled on the host machine yourself.
Good mention. Folks who try this the first time after running tuya outside of a container won't have noticed.
branch or PR for this?
Hi @pdugas, I originally added the docker-image in this project, thanks for your work! The main reason I choose an ubuntu-based-docker-image was that I could use install_prereq.sh, without always have to separately adjust packages. Perhaps we can take https://github.com/ct-Open-Source/tuya-convert/pull/890 to extend install_prereq.sh to also detect alpine_images ... I'll have a look into this in the next few days ...
I'm a little braindead today and didn't notice the project includes a Dockerfile before I'd gone ahead a rolled my own. It's simpler and builds the image much faster than the Ubuntu image you use currently so I thought I'd share in case it's of interest. Feel free to ignore this if not. There was only one hack to the existing project code needed to get it to work; busybox's
ls
doesn't support the-m
option.A companion Makefile too...