search

ct-clmsn / chplx

A Chapel backend
Apache License 2.0
4 stars 2 forks source link

Attempting to resolve issues in backend #45

Closed hkaiser closed 1 year ago

hkaiser commented 1 year ago

@ct-clmsn this is an attempt to resolve issues in the backend introduced by recent changes to handling scopes. It does not fully resolve things as I wasn't sure how things are supposed to work. Please have a careful look.

hkaiser commented 1 year ago

FWIW, with this PR, I'm seeing this when compiling forall.chpl:

chplx : for identifier already defined in current scope
chplx : i identifier already defined in current scope
chplx : i identifier already defined in current scope
chplx : i identifier already defined in current scope
chplx : i identifier already defined in current scope
chplx : coforall identifier already defined in current scope

after which the compiler segfaults here: https://github.com/ct-clmsn/chplx/blob/edcdb26facc3b1ae33ce06475d9d5aef2a515aec/backend/src/programtreebuildingvisitor.cpp#L870 as curStmts is empty.

ct-clmsn commented 1 year ago

Huh, I ran some tests on my local system before doing the commit+merge and it looked like everything checked out. Will dig into this in the evening. Thanks for looking into it.

hkaiser commented 1 year ago

These issues have been resolved by other commits. Closing now.