search

cta-epfl / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Merge upstream #25

Closed Ph0tonic closed 9 months ago

Ph0tonic commented 9 months ago

@volodymyrss here is a PR which update the general resync our fork with batchspawner. I managed to fix all tests except the one with the current dev branch of jupyterhub. I am not sure why I I needed to drop the sudo part of cmd test to make them pass. I haven't found where this sudo was dropped in our fork.

Ph0tonic commented 9 months ago

I also propose to drop support for older versions of python that we do not use (3.7 and 3.6) to be able to use latest python syntax and added some tests for python 3.12.

Ph0tonic commented 9 months ago

Ok, so tests with the non-released version of jupyterhub are failing on the official repo as well.

volodymyrss commented 9 months ago

Ok, so tests for with the non-released version of jupyterhub are failing as well.

* https://github.com/jupyterhub/batchspawner/actions/runs/7888451878/job/21526019676?pr=299

Uh. I wonder if we can just make a package "arcspawner" and only implement our spawner. Else we always have to merge upstream. What do you think? not for this PR, for later

Ph0tonic commented 9 months ago

I think that it would be a good idea and make much more sense :+1:

Ph0tonic commented 9 months ago

Shall we however merge this PR first ?