cta-epfl / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

WIP : Use certificateservice #38

Open Ph0tonic opened 6 months ago

Ph0tonic commented 6 months ago

Use CertificateService to retrieve certificate instead of relying on internal knowledge of CertificateService.

Ph0tonic commented 6 months ago

Note for myself:

The current implementation fails because when jupyterhub restarts, it does the following:

What could be done:

Warning, we would have to check that the API is already available at the time of the creation of ARCSpawner to ensure that certificateservice can indeed contact the API to authenticate the request made by batchspawner.

volodymyrss commented 6 months ago

Note for myself:

The current implementation fails because when jupyterhub restarts, it does the following:

* Tries to reconnect to sessions and create an ARCSpawner 
* When ARCSpawner tries to get certificates fro certificateservice, the service is not yet started, leading to a crash.

Is this blocking (i.e. services will not start until all sessions reconnected by creating ARCSpawner) or a just race condition?