search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
26 stars 77 forks source link

Simulation API #1055

Open maxnoe opened 1 year ago

maxnoe commented 1 year ago

One of the remaining large blocks where the GADF (and some other???) data formats are hard coded at positions where I don't expect them is the MapDatasetEventsMaker, specifically the event_list_meta function of that class.

It seems very hard to change this class in a backwards compatible way, so I would propose to deprecate that class entirely and write a new class called SimulatedObservationMaker that takes an observation (with IRFs but no event list) and source model(s) and returns the observation filled with events.

The resulting observation can then be written using the normal Observation.write method to any format supported by gammapy.

maxnoe commented 1 year ago

Sorry, this was supposed to be for gammapy.