search

cta-observatory / cta-lstchain

LST prototype testbench chain
https://cta-observatory.github.io/cta-lstchain/
BSD 3-Clause "New" or "Revised" License
24 stars 77 forks source link

Remove unused `get_cleaning_parameters` function #1170

Closed aaguasca closed 10 months ago

aaguasca commented 1 year ago

This PR removes the unused function get_cleaning_parameters from find_safe_threshold_from_dl1_file

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (fd7e1a8) 74.46% compared to head (0ebe771) 73.98%. Report is 301 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1170 +/- ## ========================================== - Coverage 74.46% 73.98% -0.49% ========================================== Files 124 124 Lines 12211 12645 +434 ========================================== + Hits 9093 9355 +262 - Misses 3118 3290 +172 ``` | [Files](https://app.codecov.io/gh/cta-observatory/cta-lstchain/pull/1170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [...stchain/calib/camera/pixel\_threshold\_estimation.py](https://app.codecov.io/gh/cta-observatory/cta-lstchain/pull/1170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-bHN0Y2hhaW4vY2FsaWIvY2FtZXJhL3BpeGVsX3RocmVzaG9sZF9lc3RpbWF0aW9uLnB5) | `27.27% <ø> (-0.99%)` | :arrow_down: | ... and [57 files with indirect coverage changes](https://app.codecov.io/gh/cta-observatory/cta-lstchain/pull/1170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

morcuended commented 10 months ago

This can be merged as well.